Skip to content

TST: Use int fixtures in test_construction.py #21588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jun 22, 2018

Title is self-explanatory.

Partially addresses #21500.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Dtype Conversions Unexpected or buggy dtype conversions Clean labels Jun 22, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Jun 22, 2018
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #21588 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21588      +/-   ##
==========================================
+ Coverage    91.9%    91.9%   +<.01%     
==========================================
  Files         153      153              
  Lines       49549    49549              
==========================================
+ Hits        45537    45539       +2     
+ Misses       4012     4010       -2
Flag Coverage Δ
#multiple 90.3% <ø> (ø) ⬆️
#single 41.78% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.27% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ffc5f...466a91f. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Jun 22, 2018

thanks!

@jreback jreback merged commit dcc0857 into pandas-dev:master Jun 22, 2018
@gfyoung gfyoung deleted the test-construction-num-fixture branch June 22, 2018 10:01
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants